Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branding icon doesn't work on Mac or Linux #87

Closed
nedtwigg opened this issue Feb 18, 2023 · 0 comments · Fixed by #117
Closed

Branding icon doesn't work on Mac or Linux #87

nedtwigg opened this issue Feb 18, 2023 · 0 comments · Fixed by #117
Labels

Comments

@nedtwigg
Copy link
Collaborator

We set the icon like so

Image icon =
loadImage(
Display.getDefault(),
IdeHookBranding.this.icon,
"dev/equo/ide/equo_icon.png");
Shell[] shells = display.getShells();
for (var shell : shells) {
shell.setText(title);
shell.setImage(icon);
shell.forceActive();
}

but this means that we are not setting all the possible sizes (e.g. 512x512, 256x256, 128x128, 64x64, 48x48, 32x32, 16x16). Windows is happy with our current approach, but the icon doesn't show up on Mac or Linux. Autoscaling the provided icon to all these sizes and setting them all should fix it.

@nedtwigg nedtwigg changed the title Improve branding icon on Mac and Linux Branding icon doesn't work on Mac or Linux Feb 18, 2023
@nedtwigg nedtwigg added bug Something isn't working plugin-gradle plugin-maven labels Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant