Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-2580 Fix server casing problem #2585

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

eliasbruvik
Copy link
Contributor

@eliasbruvik eliasbruvik commented Oct 30, 2024

Fixes

This pull request fixes #2580

Description

Changed AuthRoute so that it will match the servers with different casing.

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Desktop
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

Copy link
Collaborator

@robertbasti robertbasti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested both witsml and WITSML and seems to be working in both cases

@robertbasti robertbasti merged commit c466b3f into equinor:main Oct 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deeplinking does not work for servers if the casing differs🐛
2 participants