#2534 UID Mapping

[vaclavbasniar]

Fixes

This pull request fixes issue #2534

Description

• added modal
• added storage
• updated copy and show on server functionality
• removed connected server from list of servers in context menus
• unit tests

Type of change

• Bugfix
• New feature (non-breaking change which adds functionality)
• Enhancement of existing functionality
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Impacted Areas in Application

• Frontend
• API
• WITSML
• Desktop
• Other (please describe)

Checklist:

Communication

• I have made corresponding changes to the documentation
• PR affects application security

Code quality

• I have self-reviewed my code
• No new warnings are generated

Test coverage

• New code is covered by passing tests

Further comments

[eliasbruvik]

Sorry for taking a while. Started on a review, but not finished yet. Anyways, added some comments on things that can be improved, and some questions to help me understand the logic.

[eliasbruvik]

Can't getTargetWellboreID also be used here? Not tested, but something like

const sourceWellboreName = toCopy[0].wellboreName;

  const { targetWellId, targetWellboreId } = await getTargetWellboreID({
    sourceServerId: sourceServer.id,
    sourceWellId: sourceWellUid,
    sourceWellboreId: sourceWellboreUid,
    targetServerId: targetServer.id
  });

  let wellbore: Wellbore;
  try {
    wellbore = await WellboreService.getWellbore(
      targetWellId,
      targetWellboreId,
      null,
      targetServer
    );
  } catch {
    return; // Cancel the operation if unable to authorize to the target server.
  }

  const targetWellboreRef: WellboreReference = {
    wellUid: targetWellId,
    wellboreUid: targetWellboreId,
    wellName: wellbore?.wellName ?? sourceWellName,
    wellboreName: wellbore?.name ?? sourceWellboreName
  };

[vaclavbasniar]

Yes, I'll check that again. However, I guess this would probably need a little bit more refactoring.

[eliasbruvik]

If I map a wellbore to a wellbore on another server, and then delete the target wellbore, the mapping will exist but not the target wellbore. If I then try to use the copyToServer-functionality it asks me to create the target wellbore as expected. However, it fails with this message:

I would expect either of these (maybe this should be discussed?):

• Any mapping that exists for a wellbore that is deleted should also be removed. If this is chosen, we need to take into account what should happen if the wellbore is deleted from the query view or another application (when we don't know that it has been deleted).
• CopyToServer will create the wellbore with the mapped uid, and then copy the object over (without any errors).

[vaclavbasniar]

Yes, that's a good point, that hasn't been discussed. I think, the first solution is correct. We should probably discuss this in weekly meeting.