Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-2387 Exclude unshared mnemonics when comparing log data #2393

Merged

Conversation

janmarius
Copy link
Contributor

Fixes

This pull request fixes #2387

Description

This PR ensures that only shared mnemonics are included when comparing log data.

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Desktop
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

@janmarius janmarius marked this pull request as draft April 29, 2024 12:45
@janmarius janmarius marked this pull request as ready for review April 29, 2024 12:53
Copy link
Contributor

@eliasbruvik eliasbruvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@janmarius janmarius merged commit 3ea8818 into equinor:main Apr 29, 2024
5 checks passed
@janmarius janmarius deleted the FIX-2387-exclude-non-shared-mnemonics branch May 3, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

👉 Compare Log Data added feature
2 participants