Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-2366 Desktop Edition unfinished jobs warning message on close #2373

Merged

Conversation

janmarius
Copy link
Contributor

@janmarius janmarius commented Apr 22, 2024

Fixes

This pull request fixes #2366

Description

This PR adds a warning message that appears when the user attempts to exit the desktop edition while there are still running jobs, prompting the user to confirm that they are aware of the potential problems with exiting while there are running jobs.

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Desktop
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

@janmarius janmarius marked this pull request as draft April 22, 2024 13:18
@janmarius janmarius marked this pull request as ready for review April 22, 2024 13:38
Src/WitsmlExplorer.Desktop/src/preload/preload.ts Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Desktop/src/main/main.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@eliasbruvik eliasbruvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@janmarius janmarius merged commit ca3fc12 into equinor:main Apr 23, 2024
3 checks passed
@janmarius janmarius deleted the FIX-2366-unfinished-jobs-warning-message branch April 23, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display a warning message whenever a user attempts to quit the desktop application while any jobs are running
2 participants