Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-2367 Automatic testing of the Desktop App #2372

Merged
merged 9 commits into from
Apr 24, 2024

Conversation

eliasbruvik
Copy link
Contributor

@eliasbruvik eliasbruvik commented Apr 22, 2024

Fixes

This pull request fixes #2367

Description

Enables automatic testing of the packaged desktop application by using playwright.

To run the tests, run these commands:

  • yarn electron:pack
  • yarn test:pack

This tests the desktop application with communication between the frontend and API, but it does not connect to an actual witsml server.

Notes:

  • So far only tested on windows
  • I have not yet tested the workflow

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Desktop
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

@eliasbruvik eliasbruvik marked this pull request as draft April 22, 2024 11:50
@eliasbruvik eliasbruvik marked this pull request as ready for review April 23, 2024 13:17
Copy link
Contributor

@janmarius janmarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer checklist

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@eliasbruvik eliasbruvik merged commit b7ad640 into equinor:main Apr 24, 2024
4 checks passed
@eliasbruvik eliasbruvik deleted the FIX-2367-electronTests branch April 24, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate if tests should be added for the Electron code
2 participants