Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/1955 consistent copy mnemonic #2340

Merged
merged 8 commits into from
Apr 10, 2024
Merged

Features/1955 consistent copy mnemonic #2340

merged 8 commits into from
Apr 10, 2024

Conversation

vaclavbasniar
Copy link
Contributor

Fixes

This pull request fixes #1955

Description

Added modal to select copy mnemonics behaviour for paste and copy to server functionality.

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

@vaclavbasniar vaclavbasniar requested review from janmarius, robertbasti and eliasbruvik and removed request for janmarius and robertbasti April 4, 2024 17:10
@vaclavbasniar
- paste on the same server
ab3d7eb 
- deleting already existing mnemonics only (delete/insert)
- styling

(equinor#1955)
eliasbruvik
eliasbruvik approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@eliasbruvik eliasbruvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@vaclavbasniar vaclavbasniar merged commit 44d1373 into equinor:main Apr 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliasbruvik eliasbruvik eliasbruvik approved these changes

@janmarius janmarius Awaiting requested review from janmarius

@robertbasti robertbasti Awaiting requested review from robertbasti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consistent copy mnemonic behavior
2 participants
@vaclavbasniar @eliasbruvik