Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-182 add serviceCompany and runNumber as editable attributes in log #2060

Merged
merged 7 commits into from
Sep 25, 2023

Conversation

janmarius
Copy link
Contributor

Fixes

This pull request fixes #182

Description

This PR will introduce two new editable attributes for logs: serviceCompany and runNumber. The PR will also:

  • Make changes to the validText() method in Src\WitsmlExplorer.Frontend\components\Modals\ModalParts.tsx to validate text of varying lengths.
  • Add tests for the validText() method.
  • Add serviceCompany and runNumber to the workers CreateLogWorker and ModifyLogObjectWorker in the API.
  • Add serviceCompany and runNumber to the LogListView,
  • Add different helper texts for new and edit log mode.

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

@janmarius janmarius changed the title Fix 182 FIX-182 add serviceCompany and runNumber as editable attributes in the LOG Sep 21, 2023
@janmarius janmarius changed the title FIX-182 add serviceCompany and runNumber as editable attributes in the LOG FIX-182 add serviceCompany and runNumber as editable attributes in log Sep 21, 2023
Copy link
Contributor

@eliasbruvik eliasbruvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@janmarius janmarius merged commit 66f411d into equinor:main Sep 25, 2023
2 checks passed
@janmarius janmarius deleted the FIX-182 branch October 9, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User story: Frontend - Update LOG attributes in property window
2 participants