Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple #1151

Merged
merged 5 commits into from
Aug 5, 2022
Merged

Multiple #1151

merged 5 commits into from
Aug 5, 2022

Conversation

VincentNevermore
Copy link
Contributor

@VincentNevermore VincentNevermore commented Aug 4, 2022

add multi selection on wells with ctrl key pressed
fix #986

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2022

Codecov Report

Merging #1151 (af893ca) into master (953adab) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1151      +/-   ##
==========================================
- Coverage   38.61%   38.55%   -0.06%     
==========================================
  Files         142      142              
  Lines        7088     7099      +11     
  Branches     1827     1834       +7     
==========================================
  Hits         2737     2737              
- Misses       4319     4330      +11     
  Partials       32       32              
Impacted Files Coverage Δ
...ib/components/DeckGLMap/layers/wells/wellsLayer.ts 3.15% <0.00%> (-0.08%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@shadab-skhan shadab-skhan added enhancement New feature or request AspenTech Task owned by AspenTech map-component Issues related to the map component. labels Aug 5, 2022
Copy link
Contributor

@shadab-skhan shadab-skhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change works fine, there should also be a mechanism to clear the multipleSelectionWells. It can be like selection in windows, when we press ctrl + click, multiple files/folders gets selected, and when you do a click without ctrl pressed, the selection is cleared.

Copy link
Contributor

@shadab-skhan shadab-skhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works perfect!

@VincentNevermore VincentNevermore merged commit 7d53f23 into equinor:master Aug 5, 2022
@VincentNevermore VincentNevermore deleted the multiple branch August 5, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AspenTech Task owned by AspenTech enhancement New feature or request map-component Issues related to the map component.
Projects
None yet
3 participants