Fix attribute error in setup.py #576
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This line was causing a error due to an update to scikit-build. The issue was that the setuptools.command.test module is not put into the symbol table by the setuptools import, but it was put there during the skbuild import causing it to be available. Due to changes in scikit-build this is no longer the case and the line gives an AttributError. The rationale for this line was that scikit-builds test command implied develop (this was obnoxious), something that is no longer true. There is thus no longer any reason to keep this line, so we can fix this issue by simply removing it.
Merged
Parsing segyio.BinField type as int in PyArg_ParseTuple is no longer possible.
From Numpy 2.0 adding a numpy.float32 and a Python numeric type returns a numy.float32 when it previously returned a numpy.float64. This changes the behavior when using the Python builtin sum function on a numpy.float32 array as the internal computations now will be performed as numpy.float32 additions when it used to be numpy.float64. Passing a numpy.double(0) as a start value to the innermost sum forces the old behavior and provides consistent results for Numpy 1 and 2.
MacOS xlarge runners are no longer required for building on Apple arm64 architecture.
sveinung-r
force-pushed
the
master
branch
4 times, most recently
from
22fecb5 to
879dd76
Compare
The latest runner for MacOS is running on arm64 architecture. The cibuildwheel cross compiling for x86 fails, so we build these wheels on the latest MacOS runner that runs on x86 (macos-13).
sveinung-r
force-pushed
the
master
branch
4 times, most recently
from
44708ed to
fb5fe15
Compare
sveinung-r
force-pushed
the
master
branch
2 times, most recently
from
e66781e to
46e56da
Compare
Python 3.13 is still in pre-release, but cibuildwheels has already included it in the matrix. Some tests are failing on 3.13, but let's wait to see if this is resolved by the official release before spending time on debugging.
|
@sveinung-r Hello! I'm trying to fix the build for this package in nixpkgs, which is broken due to this error.
Thank you for creating this patch and doing the leg work of figuring out what is going on. |
|
Hei @tjni, Awesome that you package I cannot comment on the first point, but I think it is still the plan to merge the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line was causing a error due to an update to scikit-build. The issue was that the setuptools.command.test module is not put into the symbol table by the setuptools import, but it was put there during the skbuild import causing it to be available. Due to changes in scikit-build this is no longer the case and the line gives an AttributError.
The rationale for this line was that scikit-builds test command implied develop (this was obnoxious), something that is no longer true. There is thus no longer any reason to keep this line, so we can fix this issue by simply removing it.