Fix an issue where smspsec might dereference null #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindjahren
force-pushed
the
attempt_fix
branch
from
131f2b6
to
7693491
Compare
berland
reviewed
Jan 25, 2024
eivindjahren
force-pushed
the
attempt_fix
branch
2 times, most recently
from
293beb8
to
59d846b
Compare
eivindjahren
force-pushed
the
attempt_fix
branch
7 times, most recently
from
7a807c0
to
7739362
Compare
|
amend commit message to explain the consequences of this fix |
The number of blocks of 8 character strings in the RESTART keyword can now be more than 9, and in any case the file could always have the length set to something larger, leading to stack corruption. Also fixed that it was always assumed that the restart filename was relative. Before, many restart cases would have been ignored because the file was too long (or incorrectly assumed to be relative). Now, restart data will most likely be included, which could lead to unexpected changed behavior.
eivindjahren
force-pushed
the
attempt_fix
branch
from
7739362
to
eb005f9
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.