clang-format: Remove version check #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
This commit also speeds up `clang-format` when installed from PyPI. It detects whether the `clang-format` executable is a Python wrapper and finds where the actual binary is location. Co-authored-by: Zohar Malamant <[email protected]>
berland
force-pushed
the
rm_clang-format-version-check
branch
from
98463c3
to
41c2259
Compare
berland
added
the
maintenance
|
Quick question, when would one want to clang-format the code if one has installed it through pypi? I'm just missing something.. |
The text concerns the case when |
lars-petter-hauge
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also speeds up
clang-formatwhen installed from PyPI. It detects whether theclang-formatexecutable is a Python wrapper and finds where the actual binary is location.Co-authored-by: Zohar Malamant [email protected]
(This is the same as equinor/ert@0c54472)