Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ERT_HAVE_THREAD_POOL, not in use #887

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Remove ERT_HAVE_THREAD_POOL, not in use #887

merged 1 commit into from
Jan 6, 2023

Conversation

berland
Copy link
Contributor

@berland berland commented Dec 16, 2022

Issue
Resolves #869

Approach
✂️

@ertomatic
Copy link
Collaborator

Can one of the admins verify this patch?

lars-petter-hauge
lars-petter-hauge approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@lars-petter-hauge lars-petter-hauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

Are any of the defines in use though? I checked some and can't find them in the ert repository..

@berland berland merged commit 23a2a48 into equinor:main Jan 6, 2023
@berland
Copy link
Contributor Author

berland commented Jan 6, 2023

Good to go!

Are any of the defines in use though? I checked some and can't find them in the ert repository..

At least some of them are in use by ecl itself (sample check on ERT_HAVE_READLINKAT)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lars-petter-hauge lars-petter-hauge lars-petter-hauge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove ERT_HAVE_THREAD_POOL
3 participants
@berland @ertomatic @lars-petter-hauge