Improve deprecation warning for EclGrid.createRectangular #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
berland
reviewed
Dec 5, 2022
python/ecl/grid/ecl_grid.py
Outdated
| @@ -282,7 +282,7 @@ def create_rectangular(cls, dims, dV, actnum=None): | |||
|
|
|||
| warnings.warn( | |||
| "EclGrid.createRectangular is deprecated. " | |||
| + "Please used the similar method in EclGridGenerator!", | |||
| + "Please use the similar method: EclGridGenerator.createRectangular!", | |||
There was a problem hiding this comment.
I suggest also to remove the exclamation mark, it gives me CAPS LOCK connotations!
There was a problem hiding this comment.
Sure! Good observation!
hnformentin
force-pushed
the
improve_depr_warning
branch
from
84ed321
to
ffe26ef
Compare
berland
approved these changes
Dec 7, 2022
hnformentin
force-pushed
the
improve_depr_warning
branch
from
ffe26ef
to
5c09db7
Compare
|
just rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Deprecation warning had a typo and I could not understand at first glance.
Approach
Rewrite deprecations warning.