Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize build system #42

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Modernize build system #42

merged 2 commits into from
Dec 21, 2023

Conversation

kwinkunks
Copy link
Member

Fixes #28. Also updating GitHub workflows, README/CONTRIBUTING, etc.

@kwinkunks kwinkunks marked this pull request as draft December 19, 2023 13:01
@kwinkunks kwinkunks marked this pull request as ready for review December 19, 2023 13:38
@kwinkunks kwinkunks force-pushed the modernize-build-system branch 2 times, most recently from a5e7f13 to 491d54f Compare December 19, 2023 13:44
@kwinkunks kwinkunks marked this pull request as draft December 20, 2023 07:34
@berland
Copy link
Contributor

berland commented Dec 20, 2023

Draft PR or ready for review?

@kwinkunks
Copy link
Member Author

@berland Forgot about a dependency, will republish when green

@kwinkunks kwinkunks marked this pull request as ready for review December 20, 2023 12:57
@kwinkunks kwinkunks mentioned this pull request Dec 20, 2023
Fixes #28. Also updating GitHub workflows, README/CONTRIBUTING, etc.
@kwinkunks kwinkunks force-pushed the modernize-build-system branch 3 times, most recently from c9a1343 to 37ba8b4 Compare December 21, 2023 09:03
pytest-snapshottest uses imp, which was deprecated in 3.11 and gone now.
They don't look like moving
syrusakbary/snapshottest#166

Conflicts:
	.github/workflows/python-build-test.yml
Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwinkunks kwinkunks merged commit 7892da4 into main Dec 21, 2023
8 checks passed
@kwinkunks kwinkunks deleted the modernize-build-system branch December 21, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Move to single pyproject.toml build
2 participants