Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: remove deprecated constructors and replace calls to deprecate… #1120

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

asmfstatoil
Copy link
Collaborator

…d functions

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 55.20833% with 43 lines in your changes missing coverage. Please review.

Project coverage is 37.14%. Comparing base (fc1c542) to head (f38913c).

Files with missing lines Patch % Lines
src/main/java/neqsim/thermo/phase/PhaseSrkCPA.java 60.97% 27 Missing and 5 partials ⚠️
...m/thermo/phase/PhaseSrkCPA_proceduralMatrices.java 10.00% 9 Missing ⚠️
...c/main/java/neqsim/thermo/system/SystemThermo.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1120      +/-   ##
============================================
+ Coverage     36.89%   37.14%   +0.25%     
+ Complexity     5692     5687       -5     
============================================
  Files           714      713       -1     
  Lines         71411    70784     -627     
  Branches       8223     8119     -104     
============================================
- Hits          26348    26295      -53     
+ Misses        43445    42871     -574     
  Partials       1618     1618              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EvenSol
Copy link
Collaborator

EvenSol commented Sep 27, 2024

at the moment ojalgo is not used in neqsim - and file : PhaseSrkCPAojAlgo.java

can be removed.

Alternatively work should be done to change from ejml to ojalgo (might improve computational efficiency).

Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good

@asmfstatoil asmfstatoil merged commit df3d8cb into equinor:master Sep 27, 2024
6 checks passed
@asmfstatoil asmfstatoil deleted the rm_deprecations branch September 27, 2024 13:32
@EvenSol EvenSol added this to the v3.0.0 milestone Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants