Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named equipment test #1104

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

asmfstatoil
Copy link
Collaborator

No description provided.

@asmfstatoil asmfstatoil force-pushed the named_equipment_test branch 2 times, most recently from b324dd4 to 66a1252 Compare September 25, 2024 06:57
Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to force that a name is set on process equipment!

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36.73%. Comparing base (ecd3453) to head (c3afed6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...cessEquipment/distillation/DistillationColumn.java 50.00% 1 Missing ⚠️
...ation/processSystem/processModules/DPCUModule.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1104      +/-   ##
============================================
- Coverage     36.78%   36.73%   -0.06%     
+ Complexity     5700     5686      -14     
============================================
  Files           714      714              
  Lines         71654    71654              
  Branches       8231     8231              
============================================
- Hits          26358    26321      -37     
- Misses        43673    43710      +37     
  Partials       1623     1623              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmfstatoil asmfstatoil merged commit 4557d1f into equinor:master Sep 25, 2024
6 checks passed
@asmfstatoil asmfstatoil deleted the named_equipment_test branch September 25, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants