-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare for use of jneqsim #292
base: master
Are you sure you want to change the base?
Conversation
I support the change but want to test a bit before approving this. Specifically I want to verify the overload done by "from jneqsim import neqsim" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same we did in NeqsimAPI. JNeqsim should just work as a "drop in" replacement for "neqsimpython". No issues so for there, so see no reason it should not work here as well 🙂
The tests are currently failing because of conflicting definitions of python module neqsim |
I would await equinor/jneqsim#15 |
I am not sure it is worth it to do "from jneqsim import neqsim" and overwrite the package structure that neqsim python package defines, it will have funky behaviour, but I was able to make the tests work. I would still recommend "from jneqsim import neqsim as jneqsim" and have a clean separation between python neqsim package objects and java neqsim objects. It is nice to get the neqsim jars from jneqsim instead of manually updating them here :) |
We will start using the jneqsim package to link Java Neqsim to neqsim-python. The jneqsim package does not add extra Python functionality to Neqsim (it is just an interface to the Neqsim Java library), but it facilitates the generation of stubs.
If only Java functionality is needed in your Python application using Neqsim, then direct use of jneqsim is recommended. However, neqsim-python adds functionality and wrappers that can simplify calculations and shorten the scripts.
jneqsim is not yet updated to v3.0.0, so we need to wait for this version to be available for it to work.