Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the ert plugin mechanism to install forward models #75

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

verveerpj
Copy link
Contributor

@verveerpj verveerpj commented Oct 30, 2024

Resolves equinor/ert#9147

This will break Everest, to be fixed by: equinor/ert#9148

@verveerpj verveerpj self-assigned this Oct 30, 2024
@verveerpj verveerpj marked this pull request as draft October 30, 2024 16:21
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 10.52632% with 17 lines in your changes missing coverage. Please review.

Project coverage is 87.39%. Comparing base (974266c) to head (acde21c).

Files with missing lines Patch % Lines
src/everest_models/forward_models.py 0.00% 16 Missing ⚠️
src/everest_models/everest_hooks.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   87.79%   87.39%   -0.40%     
==========================================
  Files         133      134       +1     
  Lines        3350     3356       +6     
==========================================
- Hits         2941     2933       -8     
- Misses        409      423      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but maybe @yngve-sk should also take a look given he is a bit more familiar with ForwardModelStepPlugins

Copy link

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a step in the right direction, removing all the config files. This is quite generic and in the long term we should explicitly type out one forward model per script (especially if we have validations that can be put there). But with all validations still packed inside the executables I suppose it has the same behavior as the old-style format.

@verveerpj
Copy link
Contributor Author

I think we should remove the everest plugin functionality in the long run. Since the get_forward_models hook was only used in testing, I removed it as a first step. Please let me know what you think.

@verveerpj verveerpj requested review from yngve-sk and DanSava November 7, 2024 13:50
Copy link
Collaborator

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@verveerpj verveerpj merged commit 25e2cd2 into main Nov 8, 2024
14 checks passed
@verveerpj verveerpj deleted the use-ert-plugins branch November 8, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Use the ForwardModelStepPlugin functionality to install Everest forward models from everest-models
4 participants