Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

well_trajectory: use more robust validator #47

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

verveerpj
Copy link
Contributor

One of the pydantic field validators in the well trajectory forward model was not robust, because it consulted the value of another field that may not exist if a validation error occurred earlier. This PR fixes that by using a model validator as recommended by the pydantic docs.

@verveerpj verveerpj added the bug Something isn't working label Aug 15, 2024
@verveerpj verveerpj self-assigned this Aug 15, 2024
@verveerpj verveerpj force-pushed the well-traj-fix-validator branch from 7e4782d to 32eb8d0 Compare August 15, 2024 15:01
Copy link
Collaborator

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@verveerpj verveerpj merged commit 55dcc83 into main Aug 15, 2024
6 of 11 checks passed
@verveerpj verveerpj deleted the well-traj-fix-validator branch August 15, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants