Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate multi-trajectory schedule files #40

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

verveerpj
Copy link
Contributor

This PR adds the functionality to write schedule files for multi-lateral trajectories to the well trajectory forward model.

@verveerpj verveerpj self-assigned this Jul 24, 2024
Copy link
Collaborator

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 just one small question

@@ -42,7 +48,7 @@ def __exit__(self, *_) -> None:


def _save_project(project_path: str, project: rips.Project):
project_file = str(project_path / "model.rsp")
project_file = str(project_path / ".model.rsp")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path looks a bit strange to me. Why is the extra . needed ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous version of the forward model was reviewed by Equinor to be qualified as TRL4, and they asked that this file would be hidden to the user. Hence the ..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When qualifying the model, we had different expectations for the generated resinsight project. To avoid misuse or misinterpretation of the job, we decided to hide it.

@verveerpj verveerpj merged commit 0a0814a into main Jul 24, 2024
11 checks passed
@verveerpj verveerpj deleted the weltraj-generate-mlt-sched branch July 24, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants