Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Well trajectory: refactor read_trajectories #30

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Well trajectory: refactor read_trajectories #30

merged 1 commit into from
Jul 16, 2024

Conversation

verveerpj
Copy link
Contributor

This PR refactors the code for reading trajectories, and add the following:

  • Allow platforms to be missing in the configuration. In this case, the platform is assumed to be located right above the first guide point, and it is assumed that there is no kickoff point.
  • Allow the kickoff point to be missing. Normally the kickoff point is prepended to the guide points, so in this case there is effectively only the guide points.
  • Tests for the different cases are added

@verveerpj verveerpj self-assigned this Jul 4, 2024
@verveerpj verveerpj marked this pull request as draft July 4, 2024 12:32
@verveerpj verveerpj force-pushed the welltraj-refactor-read_trajectories branch 3 times, most recently from 2898b38 to 0032df5 Compare July 6, 2024 05:39
@verveerpj verveerpj marked this pull request as ready for review July 6, 2024 05:40
@verveerpj verveerpj force-pushed the welltraj-refactor-read_trajectories branch from d59da6f to 90a8755 Compare July 6, 2024 07:47
DanSava
DanSava approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice refactor 🧑‍🔧

@verveerpj verveerpj merged commit 4dd8c8c into main Jul 16, 2024
11 checks passed
@verveerpj verveerpj deleted the welltraj-refactor-read_trajectories branch July 16, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanSava DanSava DanSava approved these changes

Assignees

@verveerpj verveerpj

Labels
None yet
Projects
SCOUT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@verveerpj @DanSava