Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using cached seba data #9529

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

frode-aarstad
Copy link
Contributor

Issue
Resolves #9515

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@frode-aarstad frode-aarstad added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Dec 13, 2024
@frode-aarstad frode-aarstad self-assigned this Dec 13, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (4301b63) to head (e9e3d0f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9529      +/-   ##
==========================================
+ Coverage   91.86%   91.89%   +0.02%     
==========================================
  Files         433      433              
  Lines       26762    26762              
==========================================
+ Hits        24584    24592       +8     
+ Misses       2178     2170       -8     
Flag Coverage Δ
cli-tests 39.76% <ø> (ø)
everest-models-test 34.66% <ø> (ø)
gui-tests 72.17% <ø> (+0.05%) ⬆️
integration-test 37.22% <ø> (-0.02%) ⬇️
performance-tests 52.07% <ø> (+0.10%) ⬆️
test 40.46% <ø> (ø)
unit-tests 74.14% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@verveerpj verveerpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
christmas-review release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using CACHED_SEBA_FOLDER in test_config_branch_entry.py
4 participants