-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated slurm options MEMORY
and MEMORY_PER_CPU
#9496
Conversation
3ff2861
to
4320429
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9496 +/- ##
==========================================
- Coverage 91.94% 91.94% -0.01%
==========================================
Files 433 433
Lines 26748 26722 -26
==========================================
- Hits 24593 24569 -24
+ Misses 2155 2153 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4320429
to
8edfce3
Compare
8edfce3
to
dcdecd5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good! Had a question on the different memory formats.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ✂️ 🚀
Issue
Resolves #9465
Approach
✂️
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable