Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated slurm options MEMORY and MEMORY_PER_CPU #9496

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

jonathan-eq
Copy link
Contributor

@jonathan-eq jonathan-eq commented Dec 10, 2024

Issue
Resolves #9465

Approach
✂️

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@jonathan-eq jonathan-eq added release-notes:bug-fix Automatically categorise as bug fix in release notes release-notes:maintenance Automatically categorise as maintenance change in release notes and removed release-notes:bug-fix Automatically categorise as bug fix in release notes labels Dec 10, 2024
@jonathan-eq jonathan-eq force-pushed the fix-everest-test branch 3 times, most recently from 3ff2861 to 4320429 Compare December 10, 2024 13:00
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.94%. Comparing base (c9d43bc) to head (dcdecd5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9496      +/-   ##
==========================================
- Coverage   91.94%   91.94%   -0.01%     
==========================================
  Files         433      433              
  Lines       26748    26722      -26     
==========================================
- Hits        24593    24569      -24     
+ Misses       2155     2153       -2     
Flag Coverage Δ
cli-tests 39.41% <50.00%> (-0.01%) ⬇️
everest-models-test 34.69% <50.00%> (-0.01%) ⬇️
gui-tests 72.21% <50.00%> (+0.05%) ⬆️
integration-test 36.94% <50.00%> (-0.04%) ⬇️
performance-tests 52.00% <50.00%> (+0.01%) ⬆️
test 40.63% <50.00%> (+<0.01%) ⬆️
unit-tests 74.12% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! Had a question on the different memory formats.

Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ✂️ 🚀

@jonathan-eq jonathan-eq merged commit d875982 into equinor:main Dec 12, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
3 participants