Make bsub tests faster #9350
Merged
Make bsub tests faster #9350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not wait after last possible attempt in driver execute_with_retry
Remove retries due to stdout missing
JHolba
added
the
release-notes:skip
xjules
reviewed
Nov 26, 2024
| @@ -150,8 +150,8 @@ async def _execute_with_retry( | |||
| ) | |||
| _logger.error(error_message) | |||
| return False, error_message | |||
|
|
|||
| await asyncio.sleep(retry_interval) | |||
| if i < (total_attempts - 1): | |||
xjules
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approach
Removes a wait that is not needed after the last attempt.
Removes retries on stdout missing in one test. This one used to take 30 seconds. Now takes a few ms.
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable