Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scheduler to submit Everserver #9126

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Nov 1, 2024

Issue
Resolves #8905

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (1f00a17) to head (80ae2ab).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9126      +/-   ##
==========================================
- Coverage   90.75%   90.75%   -0.01%     
==========================================
  Files         351      351              
  Lines       21901    21901              
==========================================
- Hits        19877    19876       -1     
- Misses       2024     2025       +1     
Flag Coverage Δ
cli-tests 39.24% <ø> (-0.01%) ⬇️
gui-tests 71.75% <ø> (ø)
performance-tests 49.38% <ø> (ø)
unit-tests 79.65% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oyvindeide oyvindeide force-pushed the use_scheduler branch 4 times, most recently from 0df6429 to 96d830f Compare November 5, 2024 09:53
@oyvindeide oyvindeide force-pushed the use_scheduler branch 5 times, most recently from 292265f to ad2ee95 Compare November 12, 2024 21:37
@oyvindeide oyvindeide marked this pull request as ready for review November 12, 2024 21:56
@oyvindeide oyvindeide force-pushed the use_scheduler branch 3 times, most recently from 0e49ccd to aca6148 Compare November 13, 2024 07:48
Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧩

@oyvindeide oyvindeide merged commit c5c693e into equinor:main Nov 13, 2024
56 checks passed
@oyvindeide oyvindeide deleted the use_scheduler branch November 13, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify everest server launching
3 participants