Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for DeleteFile #8861

Merged

Conversation

HakonSohoel
Copy link
Contributor

@HakonSohoel HakonSohoel commented Oct 3, 2024

Issue
Resolves #8829

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@HakonSohoel HakonSohoel added the release-notes:skip If there should be no mention of this in release notes label Oct 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.40%. Comparing base (4bba695) to head (14d6d31).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8861      +/-   ##
==========================================
+ Coverage   91.35%   91.40%   +0.05%     
==========================================
  Files         343      344       +1     
  Lines       21087    21102      +15     
==========================================
+ Hits        19263    19289      +26     
+ Misses       1824     1813      -11     
Flag Coverage Δ
cli-tests 39.67% <ø> (+0.09%) ⬆️
gui-tests 73.50% <ø> (+0.01%) ⬆️
performance-tests 50.20% <ø> (+0.03%) ⬆️
unit-tests 79.92% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HakonSohoel HakonSohoel force-pushed the fix-documentation-for-delete-file branch from 89b1c33 to 14d6d31 Compare October 3, 2024 10:08
@HakonSohoel HakonSohoel changed the title FIx documentation for DeleteFile Fix documentation for DeleteFile Oct 3, 2024
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! 💯

@HakonSohoel HakonSohoel merged commit a342528 into equinor:main Oct 3, 2024
56 checks passed
@HakonSohoel HakonSohoel deleted the fix-documentation-for-delete-file branch October 3, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The documentation for delete file is wrong
3 participants