Run everest test in komodo #8827
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8827 +/- ##
==========================================
+ Coverage 91.36% 91.48% +0.11%
==========================================
Files 344 345 +1
Lines 21122 21267 +145
==========================================
+ Hits 19299 19457 +158
+ Misses 1823 1810 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
DanSava
force-pushed
the
run_everest_tests_in_komodo
branch
2 times, most recently
from
5e3db8c to
7a0ab13
Compare
DanSava
force-pushed
the
run_everest_tests_in_komodo
branch
3 times, most recently
from
97eeab8 to
c1ce014
Compare
ci/testkomodo.sh
Outdated
| @@ -33,6 +34,20 @@ run_ert_with_opm () { | |||
| popd | |||
| } | |||
|
|
|||
| run_everest_tests () { | |||
| if [[ -n "${CI_PR_RUN}" ]]; then | |||
There was a problem hiding this comment.
I do not think that this CI_PR_RUN variable will ever be set in komodo, so i suggest removing the if statement and only keep the first branch?
There was a problem hiding this comment.
It is good to have a confirmation that CI_PR_RUN is not a thing anymore in komodo, but why keep the first branch and the else branch? The first branch is not running the UI tests.
There was a problem hiding this comment.
Ah, I just assumed that it was the first that we used to run due to the comment, but I agree that we should also run the ui tests then.
DanSava
force-pushed
the
run_everest_tests_in_komodo
branch
from
c1ce014 to
ba9cf74
Compare
Issue
Resolves #8783
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable