Run everest tests before publishing to pypi #8756
Conversation
frode-aarstad
added
the
release-notes:skip
frode-aarstad
force-pushed
the
everest-pypi
branch
3 times, most recently
from
dc48e49 to
5249c3f
Compare
.github/workflows/test_everest.yml
Outdated
| python-version: | ||
| type: string | ||
| test-type: | ||
| type: string | ||
|
|
||
| concurrency: |
There was a problem hiding this comment.
I believe this must be removed. The concurrency inherits from build_and_test.yml from now on.
.github/workflows/build_and_test.yml
Outdated
| @@ -141,7 +155,7 @@ jobs: | |||
| publish: | |||
| name: Publish to PyPI | |||
| runs-on: ubuntu-latest | |||
| needs: [build-wheels, test-linux, test-mac-for-tags, docs-ert] | |||
| needs: [build-wheels, test-linux-ert, test-linux-everest, test-mac-for-tags-ert, docs-ert] | |||
There was a problem hiding this comment.
Should probably also have test-mac-for-tags-everest ?
There was a problem hiding this comment.
Agree. Will create that aswell
frode-aarstad
force-pushed
the
everest-pypi
branch
from
5249c3f to
4ed0daa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8756 +/- ##
==========================================
- Coverage 91.40% 91.39% -0.01%
==========================================
Files 343 343
Lines 21087 21087
==========================================
- Hits 19274 19273 -1
- Misses 1813 1814 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
frode-aarstad
force-pushed
the
everest-pypi
branch
4 times, most recently
from
bcf111a to
c6388e9
Compare
| env: | ||
| QT_QPA_PLATFORM: 'minimal' | ||
| run: | | ||
| python -m pytest tests/everest -m "ui_test" | ||
|
|
||
| - name: Build Documentation | ||
| if: matrix.test_type == 'doc' | ||
| if: inputs.test-type == 'doc' |
There was a problem hiding this comment.
I would suggest maybe combining this and the test doc entry points, and making it a separate step in the build and test workflow, so that it can be run only once for one python version to reduce the number of total workflows run? Similar to how we test the building of the ert docs.
But this can probably be done later in another pr.
There was a problem hiding this comment.
Added so docs are only build for py312
frode-aarstad
force-pushed
the
everest-pypi
branch
10 times, most recently
from
567cb20 to
8c72c36
Compare
frode-aarstad
force-pushed
the
everest-pypi
branch
from
8c72c36 to
0d3c33d
Compare
Issue
Resolves #8744
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/unit_tests -n logical -m "not integration_test"')When applicable