Combine gendata config directly #8554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yngve-sk
force-pushed
the
combine-gendata-standardize-gendata-config-directly
branch
30 times, most recently
from
0a0acca to
0a8bf06
Compare
yngve-sk
force-pushed
the
combine-gendata-standardize-gendata-config-directly
branch
2 times, most recently
from
16f451b to
091cf42
Compare
yngve-sk
force-pushed
the
combine-gendata-standardize-gendata-config-directly
branch
2 times, most recently
from
14b77be to
96e32ef
Compare
oyvindeide
reviewed
Sep 9, 2024
oyvindeide
reviewed
Sep 9, 2024
| from .response_config import ResponseConfig | ||
|
|
||
|
|
||
| class _ResponsesIndex: |
There was a problem hiding this comment.
Can you put everything related to this into a separate commit?
yngve-sk
force-pushed
the
combine-gendata-standardize-gendata-config-directly
branch
7 times, most recently
from
21398bc to
4b8c547
Compare
oyvindeide
approved these changes
Sep 10, 2024
| info = "Standardize response configs" | ||
|
|
||
|
|
||
| def _migrate_response_configs(path: Path) -> None: |
There was a problem hiding this comment.
Just as a final request, could you also check in a few more storages here: https://github.com/equinor/ert-testdata/tree/main/all_data_types so we have this properly covered?
|
Also, remember labels, etc. on the PR |
yngve-sk
force-pushed
the
combine-gendata-standardize-gendata-config-directly
branch
from
ba3b1d0 to
2ce8735
Compare
yngve-sk
force-pushed
the
combine-gendata-standardize-gendata-config-directly
branch
from
2ce8735 to
6de77cf
Compare
yngve-sk
added
the
release-notes:skip
yngve-sk
force-pushed
the
combine-gendata-standardize-gendata-config-directly
branch
from
6de77cf to
384e228
Compare
yngve-sk
force-pushed
the
combine-gendata-standardize-gendata-config-directly
branch
from
384e228 to
70aaf52
Compare
yngve-sk
added
release-notes:breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just testing