Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write reponse as yaml #7692

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Write reponse as yaml #7692

merged 1 commit into from
Apr 18, 2024

Conversation

frode-aarstad
Copy link
Contributor

@frode-aarstad frode-aarstad commented Apr 18, 2024

Issue
Resolves #7609

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@frode-aarstad frode-aarstad self-assigned this Apr 18, 2024
@frode-aarstad frode-aarstad added the release-notes:improvement Automatically categorise as improvement in release notes label Apr 18, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.82%. Comparing base (e4d8f7f) to head (2156882).

Files Patch % Lines
src/ert/gui/ertwidgets/storage_info_widget.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7692      +/-   ##
==========================================
- Coverage   84.82%   84.82%   -0.01%     
==========================================
  Files         383      383              
  Lines       23261    23262       +1     
  Branches      884      887       +3     
==========================================
- Hits        19732    19731       -1     
- Misses       3418     3419       +1     
- Partials      111      112       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dafeda
Copy link
Contributor

dafeda commented Apr 18, 2024

image

Looks good.

@frode-aarstad frode-aarstad merged commit c86ab2d into equinor:main Apr 18, 2024
37 checks passed
@frode-aarstad frode-aarstad deleted the yaml-dump branch April 18, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Experiment mananger write reponse as yaml
3 participants