Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move duplicate ev_types to ert/event_type_constants.py #7683

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Move duplicate ev_types to ert/event_type_constants.py #7683

merged 1 commit into from
Apr 17, 2024

Conversation

jonathan-eq
Copy link
Contributor

@jonathan-eq jonathan-eq commented Apr 16, 2024 •
edited
Loading

Issue
Resolves #6457

Approach
The commit in this PR moves duplicate event type constants found in job_queue/queue.py and ensemble_evaluator/identifiers.py into a common module ert/event_type_constants.py

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@jonathan-eq
Move duplicate ev_types to ert/event_type_constants.py
aec83ee 
This commit moves duplicate event type constants found in `job_queue/queue.py` and `ensemble_evaluator/identifiers.py` into a common module `ert/event_type_constants.py`
@jonathan-eq jonathan-eq added improvement Something nice to have, that will make life easier for developers or users or both. release-notes:skip If there should be no mention of this in release notes labels Apr 16, 2024
xjules
xjules approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @jonathan-eq !

@jonathan-eq jonathan-eq merged commit 29d0fe4 into equinor:main Apr 17, 2024
37 checks passed
@eivindjahren eivindjahren mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xjules xjules xjules approved these changes

Assignees
No one assigned
Labels
improvement Something nice to have, that will make life easier for developers or users or both. release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicated defininition of event values
2 participants
@jonathan-eq @xjules