Reduce timeout in order to speed up tests #7678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the test id's that are expected to timeout (5 of them), the test runtime will indeed be the timeout. 0.2 has been proven to be too small (the initial commit) for MacOS runners. 5 seconds is proven to be sufficient, but is probably overkill. Try 1 second as a middle ground.
berland
added
the
release-notes:skip
jonathan-eq
approved these changes
Apr 16, 2024
| @@ -453,7 +453,7 @@ async def test_faulty_bjobs(monkeypatch, tmp_path, bjobs_script, expectation): | |||
| driver = LsfDriver() | |||
| with expectation: | |||
| await driver.submit(0, "sleep") | |||
| await asyncio.wait_for(poll(driver, {0}), timeout=5) | |||
| await asyncio.wait_for(poll(driver, {0}), timeout=1) | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7678 +/- ##
==========================================
- Coverage 84.84% 84.76% -0.08%
==========================================
Files 383 383
Lines 23301 23301
Branches 880 877 -3
==========================================
- Hits 19770 19752 -18
- Misses 3417 3436 +19
+ Partials 114 113 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the test id's that are expected to timeout (5 of them), the test runtime will indeed be the timeout. 0.2 has been proven to be too small (the initial commit) for MacOS runners. 5 seconds is proven to be sufficient, but is probably overkill. Try 1 second as a middle ground.
Issue
Resolves 25 seconds to run one test function (reduced to 5 seconds).
Approach
Shorten timeout
When applicable