Increase timeout for cluster integration tests #7620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default timeout at 10 minutes can be too low if the compute cluster has low availability of compute resources, as the time spent waiting in the queue for a compute job is counted. Increasing the timeout to 1 hour only when running the tests against the real compute cluster. The timeout for the test_kill had to be removed, as that test can also suffer the same problem. Note that this can then hide a bug for the LSF driver as the driver cannot distuingish between which will happen when the job is not killed and the exit code when it is killed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7620 +/- ##
=======================================
Coverage 85.18% 85.18%
=======================================
Files 383 383
Lines 23305 23305
Branches 879 886 +7
=======================================
Hits 19852 19852
- Misses 3343 3346 +3
+ Partials 110 107 -3 ☔ View full report in Codecov by Sentry. |
berland
added
release-notes:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default timeout at 10 minutes can be too low if the compute cluster has low availability of compute resources, as the time spent waiting in the queue for a compute job is counted. Increasing the timeout to 1 hour only when running the tests against the real compute cluster.
The timeout for the test_kill had to be removed, as that test can also suffer the same problem. Note that this can then hide a bug for the LSF driver as the driver cannot distuingish between which will happen when the job is not killed and the exit code when it is killed.
Issue
Resolves #7595
Approach
➕
When applicable