Rename Job.__call__ to job.run in scheduler #7615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-eq
added
maintenance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7615 +/- ##
==========================================
+ Coverage 84.50% 85.18% +0.67%
==========================================
Files 383 383
Lines 23305 23305
Branches 886 883 -3
==========================================
+ Hits 19694 19852 +158
+ Misses 3503 3345 -158
Partials 108 108 ☔ View full report in Codecov by Sentry. |
jonathan-eq
force-pushed
the
rename-job__call__-in-scheduler
branch
from
8e20302 to
bae11c0
Compare
xjules
reviewed
Apr 10, 2024
| @@ -91,7 +91,7 @@ async def test_submitted_job_is_cancelled(realization, mock_event): | |||
| ], | |||
| ) | |||
| @pytest.mark.asyncio | |||
| async def test_call( | |||
| async def test_run( | |||
There was a problem hiding this comment.
rename suggestion: test_that_job_run_successfully ?
jonathan-eq
force-pushed
the
rename-job__call__-in-scheduler
branch
from
bae11c0 to
740e865
Compare
xjules
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #7591
Approach
The commit in this PR renames Job.call to job.run in scheduler.
(Screenshot of new behavior in GUI if applicable)
When applicable