Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storage instance used outside of storage context #7614

Merged

Conversation

jonathan-eq
Copy link
Contributor

No description provided.

@jonathan-eq jonathan-eq self-assigned this Apr 10, 2024
@jonathan-eq jonathan-eq added improvement Something nice to have, that will make life easier for developers or users or both. release-notes:skip If there should be no mention of this in release notes labels Apr 10, 2024
@jonathan-eq jonathan-eq requested a review from yngve-sk April 10, 2024 05:47
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.19%. Comparing base (afd2437) to head (fa63e2d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7614      +/-   ##
==========================================
+ Coverage   84.11%   85.19%   +1.07%     
==========================================
  Files         383      383              
  Lines       23305    23305              
  Branches      886      876      -10     
==========================================
+ Hits        19603    19854     +251     
+ Misses       3594     3339     -255     
- Partials      108      112       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!🚀

@jonathan-eq jonathan-eq enabled auto-merge (rebase) April 10, 2024 06:45
@jonathan-eq jonathan-eq force-pushed the fix-storage-context-indentation branch from 9ad566b to fa63e2d Compare April 10, 2024 07:09
@jonathan-eq jonathan-eq merged commit 880886e into equinor:main Apr 10, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something nice to have, that will make life easier for developers or users or both. release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants