Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let mocked bkill support specific kill signal #7599

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

berland
Copy link
Contributor

@berland berland commented Apr 9, 2024

The tests sent a -s option to the mock that failed the mock. Another error (missing timeout) let the kill test pass when it should not.

Issue
Resolves #7598

Approach
Add timeout to fail the test, then fix the mock and pass the test.

(since the LSF driver does not return the correct return code, the assert on return code did not otherwise fail the test as it would for PBS driver)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

The tests sent a -s option to the mock that failed the mock.
Another error (missing timeout) let the kill test pass when
it should not.
@berland berland self-assigned this Apr 9, 2024
@berland berland added the release-notes:skip If there should be no mention of this in release notes label Apr 9, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.50%. Comparing base (3469d56) to head (97ad740).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7599      +/-   ##
==========================================
- Coverage   85.19%   84.50%   -0.70%     
==========================================
  Files         384      384              
  Lines       23310    23310              
  Branches      879      877       -2     
==========================================
- Hits        19860    19698     -162     
- Misses       3341     3498     +157     
- Partials      109      114       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jonathan-eq jonathan-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!👌

@berland berland merged commit cfad65e into equinor:main Apr 9, 2024
37 checks passed
@berland berland deleted the fix_lsf_mocked_kill branch May 29, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mocked bkill.py not compatible with current lsf_driver.py
3 participants