Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use macOS-14 runners for ert #7592

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Apr 8, 2024

Building tags

OS Arch 3.8 3.9 3.10 3.11 3.12
macOS-14 arm64
macOS-14-large x86_64
macOS-13 x86_64

Testing tags

OS Arch 3.8 3.12
macOS-14 arm64
macOS-14-large x86_64
macOS-13 x86_64

Works fine on macOS-14
https://github.com/equinor/ert/actions/runs/8600062307

Use tag macos-latest when doing regular build and test for PR's since we have some included minutes for those specific runners.
Eventually (12 week window or so) these will not point at macos-12, but macos-14.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@andreas-el andreas-el force-pushed the use_macos14_runners branch from 67cf5d5 to fac8444 Compare April 8, 2024 13:17
@andreas-el andreas-el self-assigned this Apr 8, 2024
@andreas-el andreas-el added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Apr 8, 2024
@andreas-el andreas-el changed the title Test macOS-14 runners for ert Use macOS-14 runners for ert Apr 8, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.19%. Comparing base (7145a29) to head (fac8444).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7592   +/-   ##
=======================================
  Coverage   85.19%   85.19%           
=======================================
  Files         388      388           
  Lines       23338    23338           
  Branches      893      884    -9     
=======================================
  Hits        19883    19883           
+ Misses       3348     3344    -4     
- Partials      107      111    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreas-el andreas-el force-pushed the use_macos14_runners branch from fac8444 to 3f0aeae Compare April 8, 2024 14:08
@andreas-el andreas-el requested a review from sondreso April 9, 2024 08:02
@andreas-el andreas-el merged commit 0e3f9b5 into equinor:main Apr 9, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants