Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure no underflow in parameter_example_test #7580

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Ensure no underflow in parameter_example_test #7580

merged 1 commit into from
Apr 5, 2024

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Apr 5, 2024 •
edited
Loading

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren requested a review from larsevj April 5, 2024 13:13
@eivindjahren eivindjahren added the release-notes:skip If there should be no mention of this in release notes label Apr 5, 2024
larsevj
larsevj approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@larsevj larsevj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@eivindjahren eivindjahren enabled auto-merge (rebase) April 5, 2024 13:29
@eivindjahren eivindjahren merged commit 9c51f1c into equinor:main Apr 5, 2024
37 checks passed
@eivindjahren eivindjahren mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsevj larsevj larsevj approved these changes

Assignees
No one assigned
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eivindjahren @larsevj