Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor storage migrations #7570

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Apr 5, 2024

Issue
Resolves #7378

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@oyvindeide oyvindeide force-pushed the refactor_migrations branch 2 times, most recently from f9a1532 to 4b447b2 Compare April 5, 2024 12:24
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.29730% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.15%. Comparing base (b090537) to head (4b447b2).

Files Patch % Lines
src/ert/storage/migration/to5.py 93.10% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7570       +/-   ##
===========================================
+ Coverage   34.92%   85.15%   +50.23%     
===========================================
  Files         388      385        -3     
  Lines       23323    23295       -28     
  Branches      893      876       -17     
===========================================
+ Hits         8146    19838    +11692     
+ Misses      15070     3343    -11727     
- Partials      107      114        +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oyvindeide oyvindeide force-pushed the refactor_migrations branch 3 times, most recently from bb48746 to fc2d5a0 Compare April 5, 2024 13:17
@oyvindeide oyvindeide self-assigned this Apr 5, 2024
@oyvindeide oyvindeide added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Apr 5, 2024
Copy link
Contributor

@pinkwah pinkwah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nitpick

src/ert/storage/local_storage.py Outdated Show resolved Hide resolved
@oyvindeide oyvindeide force-pushed the refactor_migrations branch from fc2d5a0 to 6073dce Compare April 8, 2024 13:28
@oyvindeide oyvindeide enabled auto-merge (rebase) April 8, 2024 13:28
@oyvindeide oyvindeide force-pushed the refactor_migrations branch from 6073dce to 4a61ae2 Compare April 8, 2024 13:39
@oyvindeide oyvindeide merged commit 85fd3cd into equinor:main Apr 8, 2024
37 checks passed
@oyvindeide oyvindeide deleted the refactor_migrations branch April 8, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor storage migrations
3 participants