-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor storage migrations #7570
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindeide
force-pushed
the
refactor_migrations
branch
2 times, most recently
from
April 5, 2024 12:24
f9a1532
to
4b447b2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7570 +/- ##
===========================================
+ Coverage 34.92% 85.15% +50.23%
===========================================
Files 388 385 -3
Lines 23323 23295 -28
Branches 893 876 -17
===========================================
+ Hits 8146 19838 +11692
+ Misses 15070 3343 -11727
- Partials 107 114 +7 ☔ View full report in Codecov by Sentry. |
oyvindeide
force-pushed
the
refactor_migrations
branch
3 times, most recently
from
April 5, 2024 13:17
bb48746
to
fc2d5a0
Compare
oyvindeide
added
the
release-notes:maintenance
Automatically categorise as maintenance change in release notes
label
Apr 5, 2024
pinkwah
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nitpick
oyvindeide
force-pushed
the
refactor_migrations
branch
from
April 8, 2024 13:28
fc2d5a0
to
6073dce
Compare
oyvindeide
force-pushed
the
refactor_migrations
branch
from
April 8, 2024 13:39
6073dce
to
4a61ae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #7378
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
When applicable