Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an experiment info widget #7525

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

frode-aarstad
Copy link
Contributor

@frode-aarstad frode-aarstad commented Mar 26, 2024

Issue
Resolves #7507

bilde

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@frode-aarstad
Copy link
Contributor Author

bilde

@frode-aarstad frode-aarstad force-pushed the experiment-info-widget branch 3 times, most recently from f7a647f to f25ae99 Compare April 2, 2024 11:39
@frode-aarstad frode-aarstad self-assigned this Apr 3, 2024
@frode-aarstad frode-aarstad force-pushed the experiment-info-widget branch from f25ae99 to 3091929 Compare April 3, 2024 07:39
Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We could consider using yaml.dump instead, it looks a bit nicer for responses, but for GEN_KW the json is not very nice, so we might want to refactor that a bit. Does not have to be in this PR though.

@frode-aarstad frode-aarstad merged commit 53daee4 into equinor:main Apr 4, 2024
37 checks passed
@frode-aarstad frode-aarstad deleted the experiment-info-widget branch April 4, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking an experiment in the Experiment manager show show experiment info
2 participants