Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ruff also as formatter #7503

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Use ruff also as formatter #7503

merged 1 commit into from
Apr 5, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Mar 21, 2024 •
edited
Loading

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@larsevj larsevj force-pushed the use_ruff_as_formatter branch 2 times, most recently from b07e792 to a68c0a9 Compare March 21, 2024 15:37
@larsevj larsevj force-pushed the use_ruff_as_formatter branch 2 times, most recently from c801375 to 393a3b8 Compare April 3, 2024 08:37
@larsevj larsevj marked this pull request as ready for review April 3, 2024 08:38
@larsevj larsevj force-pushed the use_ruff_as_formatter branch from 393a3b8 to 3d8b8c6 Compare April 3, 2024 10:21
@larsevj larsevj force-pushed the use_ruff_as_formatter branch from 3d8b8c6 to bdb5cc7 Compare April 3, 2024 10:23
@larsevj larsevj requested review from berland and oyvindeide April 3, 2024 10:59
oyvindeide
oyvindeide approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@larsevj larsevj added the release-notes:skip If there should be no mention of this in release notes label Apr 5, 2024
@larsevj larsevj merged commit b21fab1 into equinor:main Apr 5, 2024
37 checks passed
@larsevj larsevj deleted the use_ruff_as_formatter branch April 5, 2024 07:18
@eivindjahren eivindjahren mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oyvindeide oyvindeide oyvindeide approved these changes

@berland berland Awaiting requested review from berland

Assignees
No one assigned
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larsevj @oyvindeide