Test that pbs driver ignores qstat flakiness #7414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berland
reviewed
Mar 11, 2024
jonathan-eq
force-pushed
the
fix-pbs_iff
branch
2 times, most recently
from
0831ed8 to
4ceb026
Compare
jonathan-eq
force-pushed
the
fix-pbs_iff
branch
5 times, most recently
from
6a88089 to
22f416c
Compare
|
|
jonathan-eq
force-pushed
the
fix-pbs_iff
branch
from
22f416c to
eb157fa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7414 +/- ##
==========================================
+ Coverage 84.78% 85.24% +0.46%
==========================================
Files 386 386
Lines 22993 22993
Branches 883 878 -5
==========================================
+ Hits 19495 19601 +106
+ Misses 3384 3278 -106
Partials 114 114 ☔ View full report in Codecov by Sentry. |
jonathan-eq
force-pushed
the
fix-pbs_iff
branch
5 times, most recently
from
82e13a7 to
f7f5226
Compare
jonathan-eq
changed the title
jonathan-eq
added
testing
release-notes:skip
berland
reviewed
Mar 19, 2024
berland
reviewed
Mar 19, 2024
berland
reviewed
Mar 19, 2024
jonathan-eq
force-pushed
the
fix-pbs_iff
branch
2 times, most recently
from
636e3b1 to
fc451e3
Compare
berland
reviewed
Mar 25, 2024
|
@berland Should I squash all commits in this PR, or merge with rebase? |
|
It looks like the first and the fourth at least should be squashed. You may squash all of them if that is the easiest then. |
|
You need to rebase @jonathan-eq |
|
When auto-merging with squash, I would like the squash to be done manually upfront to ensure the commit message is sound. |
This commit: * Moves QSTAT_HEADER stub constants to tests/conftests.py * Adds tests for OpenPBS driver ignoring qstat flakiness * Updates the qstat mocked binary to mimick the qstat wide option * Makes the OpenPBS tests use the common qstat fixture
berland
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #7357
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
When applicable