Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove benchmarking files not in use #7111

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

jonathan-eq
Copy link
Contributor

No description provided.

@jonathan-eq jonathan-eq added maintenance Not a bug now but could be one day, repaying technical debt release-notes:skip If there should be no mention of this in release notes labels Feb 5, 2024
@jonathan-eq jonathan-eq self-assigned this Feb 5, 2024
Remove benchmarking files created by dark storage performance benchmarks. They are not in use as we are not comparing results anymore.
@jonathan-eq jonathan-eq force-pushed the remove-unused-benchmarks branch from 6c44e6f to 70e7176 Compare February 7, 2024 09:42
@berland
Copy link
Contributor

berland commented Feb 7, 2024

How to assert that these are not in use? But I have enough faith, so 🥓

@jonathan-eq
Copy link
Contributor Author

I am pretty sure that I added them back when I first introduced the dark storage benchmarking workflow

@jonathan-eq jonathan-eq enabled auto-merge (squash) February 7, 2024 10:27
@jonathan-eq jonathan-eq merged commit 7936479 into equinor:main Feb 7, 2024
51 checks passed
@jonathan-eq jonathan-eq deleted the remove-unused-benchmarks branch February 7, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug now but could be one day, repaying technical debt release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants