Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setAlignment that just loops forever #7100

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Feb 5, 2024

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren added the release-notes:skip If there should be no mention of this in release notes label Feb 5, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e35e7e0) 84.83% compared to head (9e94708) 85.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7100      +/-   ##
==========================================
+ Coverage   84.83%   85.30%   +0.46%     
==========================================
  Files         379      379              
  Lines       22546    22544       -2     
  Branches     1025     1022       -3     
==========================================
+ Hits        19127    19231     +104     
+ Misses       3307     3196     -111     
- Partials      112      117       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be gone already! 🪨

@eivindjahren eivindjahren merged commit 87e3593 into equinor:main Feb 5, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants