Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migration from 8.0.12 to 8.4.x #7080

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

frode-aarstad
Copy link
Contributor

Issue
Resolves #7068

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@frode-aarstad frode-aarstad added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Feb 2, 2024
@frode-aarstad frode-aarstad self-assigned this Feb 2, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b7eb02) 83.72% compared to head (982d447) 83.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7080   +/-   ##
=======================================
  Coverage   83.72%   83.73%           
=======================================
  Files         367      367           
  Lines       22138    22139    +1     
  Branches     1011     1011           
=======================================
+ Hits        18535    18538    +3     
+ Misses       3289     3287    -2     
  Partials      314      314           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kvashchuka kvashchuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works now! thanks for fixing this!

@frode-aarstad frode-aarstad merged commit 22b5cd4 into equinor:main Feb 2, 2024
51 checks passed
@frode-aarstad frode-aarstad deleted the fix-migration branch September 23, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage migration doesn't work from ert 8.0.12 to ert 8.4.x
3 participants