Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create remove button in Manage Cases #7032

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Jan 28, 2024

Removal of cases is not yet supported

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@dafeda dafeda force-pushed the add-remove-widget branch from 7e03767 to 2ce6b84 Compare January 30, 2024 12:02
@dafeda dafeda self-assigned this Jan 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1bc3524) 85.90% compared to head (334ba12) 85.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7032      +/-   ##
==========================================
- Coverage   85.90%   85.90%   -0.01%     
==========================================
  Files         379      379              
  Lines       22559    22550       -9     
  Branches      940      934       -6     
==========================================
- Hits        19380    19372       -8     
+ Misses       3063     3061       -2     
- Partials      116      117       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dafeda dafeda added release-notes:skip If there should be no mention of this in release notes maintenance Not a bug now but could be one day, repaying technical debt labels Jan 31, 2024
Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dafeda dafeda force-pushed the add-remove-widget branch 7 times, most recently from 0ebf21c to 601cd04 Compare February 7, 2024 12:47
We want to support this but needs design
@dafeda dafeda force-pushed the add-remove-widget branch from 601cd04 to 334ba12 Compare February 9, 2024 07:49
@dafeda dafeda merged commit 5072a4e into equinor:main Feb 9, 2024
51 checks passed
@dafeda dafeda deleted the add-remove-widget branch February 9, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug now but could be one day, repaying technical debt release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants