Summary observations are now matched against responses with nearest time (1 second tolerance) #6988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindjahren
force-pushed
the
add_cludge
branch
4 times, most recently
from
91e519a to
fa0125d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6988 +/- ##
==========================================
+ Coverage 84.39% 84.48% +0.08%
==========================================
Files 367 366 -1
Lines 21884 21794 -90
Branches 900 900
==========================================
- Hits 18470 18412 -58
+ Misses 3120 3088 -32
Partials 294 294 ☔ View full report in Codecov by Sentry. |
eivindjahren
force-pushed
the
add_cludge
branch
from
fa0125d to
d628699
Compare
eivindjahren
force-pushed
the
add_cludge
branch
2 times, most recently
from
7cdce3d to
15eb39a
Compare
eivindjahren
changed the title
eivindjahren
added
the
release-notes:bug-fix
oyvindeide
reviewed
Jan 23, 2024
| f""" | ||
| NUM_REALIZATIONS 2 | ||
| ECLBASE CASE | ||
| SUMMARY FOPR |
There was a problem hiding this comment.
Not needed because of the SUMMARY_OBSERVATION (but can be here)
eivindjahren
force-pushed
the
add_cludge
branch
3 times, most recently
from
68c969d to
3983237
Compare
oyvindeide
approved these changes
Jan 24, 2024
| @@ -316,7 +316,8 @@ def _read_spec( | |||
| hour=hour, | |||
| minute=minute, | |||
| second=microsecond // 10**6, | |||
| microsecond=microsecond % 10**6, | |||
| # Due to https://github.com/equinor/ert/issues/6952 | |||
There was a problem hiding this comment.
Could you make this comment stand-alone? Otherwise I foresee a future where the below line will simply be deleted, as I assume that it is related to this?
| start_date + unit.make_delta(float(vals[date_index])) | ||
| ), | ||
| ) | ||
| # Due to https://github.com/equinor/ert/issues/6952 |
There was a problem hiding this comment.
Could you make this comment stand-alone? Otherwise I foresee a future where the below line will simply be deleted, as I assume that it is related to this?
eivindjahren
force-pushed
the
add_cludge
branch
2 times, most recently
from
b9fa349 to
b096a40
Compare
Since summary files have precision loss of time, we need to include some tolerance when matching responses to observations. Also contains a workaround for storage not handling datetimes with microseconds due to index overflow in netcdf3. equinor#6952
eivindjahren
force-pushed
the
add_cludge
branch
from
b096a40 to
b497435
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since summary files have precision loss of time, we need to include some
tolerance when matching responses to observations.
Also contains a workaround for storage not handling datetimes with
microseconds due to index overflow in netcdf3.
#6952
The added test currently takes ~40s to run, but improvements to ensemble_evaluator startup overhead (which is being worked on) should fix this.
When applicable