Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commitin #6982

Closed
wants to merge 1 commit into from
Closed

Commitin #6982

wants to merge 1 commit into from

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Jan 22, 2024

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0465891) 84.37% compared to head (86f980a) 84.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6982      +/-   ##
==========================================
+ Coverage   84.37%   84.39%   +0.02%     
==========================================
  Files         367      367              
  Lines       21882    21882              
  Branches      900      900              
==========================================
+ Hits        18462    18468       +6     
+ Misses       3126     3120       -6     
  Partials      294      294              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dafeda dafeda closed this Jan 22, 2024
@dafeda dafeda reopened this Jan 22, 2024
@dafeda dafeda closed this Jan 22, 2024
@dafeda dafeda deleted the flaky branch January 22, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants