Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark two scheduler tests as flaky #6980

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Mark two scheduler tests as flaky #6980

merged 1 commit into from
Jan 22, 2024

Conversation

berland
Copy link
Contributor

@berland berland commented Jan 22, 2024 •
edited
Loading

These have been seen to be flaky but will pass on retries

Approach
Rerun instead of tuning timing limits

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland added the release-notes:skip If there should be no mention of this in release notes label Jan 22, 2024
@berland berland self-assigned this Jan 22, 2024
@jonathan-eq jonathan-eq self-requested a review January 22, 2024 06:24
@berland berland changed the title Mark two scheculer tests as flaky Mark two scheduler tests as flaky Jan 22, 2024
@berland
Mark two scheduler tests as flaky
0cd2cc4 
These have been seen to be flaky but will pass on retries. Rerunning
instead of tuning the timing requirements will keep the timing
requirements easier to understand.
jonathan-eq
jonathan-eq approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@jonathan-eq jonathan-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@berland berland enabled auto-merge (squash) January 22, 2024 06:26
@berland berland merged commit 0465891 into equinor:main Jan 22, 2024
42 of 43 checks passed
@berland berland deleted the mark_flaky branch September 17, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-eq jonathan-eq jonathan-eq approved these changes

Assignees

@berland berland

Labels
release-notes:skip If there should be no mention of this in release notes
Projects
SCOUT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berland @jonathan-eq